remove max file size check in openExistingOrNew #50
Conversation
Signed-off-by: Arjun Raja Yogidas <[email protected]>
| @@ -284,10 +284,6 @@ func (l *Logger) openExistingOrNew(writeLen int) error { | |||
| return fmt.Errorf("error getting log file info: %s", err) | |||
| } | |||
|
|
|||
| if info.Size()+int64(writeLen) >= l.max(int64(writeLen)) { | |||
There was a problem hiding this comment.
lets say we set a size and the new check starts just at the border when the file is at max size but not yet at the tipping point, removing this check can potentially make the file not rotate?
There was a problem hiding this comment.
This function in called within the write function where there is another check to ensure that the logs don't overflow.
if l.size+writeLen > l.max(writeLen)
|
Thanks @coderbirju, could you please add a test to control this behavior! |
coderbirju
force-pushed
the
update-logrotate
branch
2 times, most recently
from
900978e to
6aa59a1
Compare
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
update-logrotate
branch
from
6aa59a1 to
7ec92c8
Compare
|
Updated the comments and added a test case for the openExistingOrNew function. PTAL. Thanks |
Thanks. Is it possible to make test with |
The current implementation of logrotate.openExistingOrNew has multiple checks to verify if there is an memory overflow on the existing log file and rotates it if true.
This code in particular checks the current log file size when logger.size is not yet set. (which defaults l.size to 0)
The max function always returns a number less than
filesize + writeLenresulting in the rotate function being called. This behavior is seen when maxBytes is set to -1.This results in nerdctl container logs failing to persist in the same log file as each new write rotates the logs and overwrites the older log file.
nerdctl issue